[18.0][REV+OU-FIX] openupgrade_framework: Revert version assignation + event_product: remove decorator #5151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…run scripts" This reverts commit 576daf1.
Contributor
|
Hi @hbrunn, @StefanRijnhart, @legalsylvain, |
`@openupgrade.migrate` decorator avoids to execute the script if version is none. As we have reverted the openupgrade_framework patch that modifies the version, we avoid the side effect and get this script working removing the decorator.
pedrobaeza
force-pushed
the
18.0-fix-framework-version
branch
from
e7c8be7 to
ba949be
Compare
Member
Author
|
And that's it! Migration scripts are still being executed for the split module: https://github.com/OCA/OpenUpgrade/actions/runs/16076314034/job/45372272328?pr=5151#step:13:2683 @hparfr can you try with your case if the error is gone? |
|
Thanks @pedrobaeza !
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "[FIX] openupgrade_framework: manipulate versions to actually run scripts"
event_product: Adapt to run it always
@openupgrade.migratedecorator avoids to execute the script if version is none. As we have reverted the openupgrade_framework patch that modifies the version, we avoid the side effect and get this script working removing the decorator.